-
Notifications
You must be signed in to change notification settings - Fork 4
Completion of k8s deployment #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Completion of k8s deployment #16
Conversation
|
Hey @priyansh-narang2308! Thank you for opening a pull request. Make sure to tag the maintainers and link the issue you are solving in your pull-request description if you have not already and they'll review as soon as possible. |
|
Hey @Ashrockzzz2003 Sorry for that , here is the new PR with the same changes |
|
It'll help if you can update the README or add one for this |
|
/bounty 500 @priyansh-narang2308 |
|
Another day, another coin. Way to get that bounty @priyansh-narang2308 you glorious keyboard-tapping, coffee-sipping, vibe-coding witcher! |
|
/impact @priyansh-narang2308 |
|
What an IMPACT! Consider my tiny, shriveled heart officially impressed. Now, go and grab yourself a latte @priyansh-narang2308. You have earned it! |
|
sure will add the readme |
kubernetes/evolve-secrets.yaml
Outdated
| minio-access-key: <BASE64_ENCODED_VALUE> | ||
| minio-secret-key: <BASE64_ENCODED_VALUE> | ||
| rabbitmq-url: <BASE64_ENCODED_VALUE> | ||
| rabbitmq-queue-name: <BASE64_ENCODED_VALUE> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its redis now as per the repo code...check out runner_controller, runner
| secretKeyRef: | ||
| name: evolve-secrets | ||
| key: minio-secret-key | ||
| - name: RABBITMQ_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its redis now, rabbitmq no longer there. check out repo
kubernetes/runner-deployment.yaml
Outdated
| secretKeyRef: | ||
| name: evolve-secrets | ||
| key: minio-secret-key | ||
| - name: RABBITMQ_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same goes here
|
the deployment should've failed Check out |
|
The deployment succeede in k8s coz the manifests were syntactically valid,but the pods wudhave failed at runtime. I've now updated to use Redis and synced the env with the docker-compose.yml |
|
Can you also add a step where we got the test endpoint in each pod to determine if it's healthy And then actually try the app that comes up after deployment to see if it works? |
Re-opening this as a new PR because the previous one (#15) was closed due to a repository deletion mishap. All changes are the same